Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request: Added "optimismSepolia" network for Testnet #2896

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

request: Added "optimismSepolia" network for Testnet #2896

wants to merge 4 commits into from

Conversation

nidz-the-fact
Copy link

@nidz-the-fact nidz-the-fact commented Sep 20, 2024 •
edited
Loading

Description

Added "optimismSepolia" network for Testnet

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

None

Showcase (Optional)

None

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: f4947bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@reown/appkit Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-wagmi Patch
@reown/appkit-ethers Patch
@reown/appkit-ethers5 Patch
@reown/appkit-solana Patch
@apps/demo Patch
@apps/laboratory Patch
@examples/html-ethers Patch
@examples/html-ethers5 Patch
@examples/html-wagmi Patch
@examples/next-ethers Patch
@examples/next-wagmi Patch
@examples/react-ethers Patch
@examples/react-ethers5 Patch
@examples/react-solana Patch
@examples/react-wagmi Patch
@examples/vue-ethers5 Patch
@examples/vue-solana Patch
@examples/vue-wagmi Patch
@reown/appkit-cdn Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Sep 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 23, 2024 1:46pm

@vercel Vercel
Copy link

vercel bot commented Sep 20, 2024

@nidz-the-fact is attempting to deploy a commit to the Reown Team on Vercel.

A member of the Team first needs to authorize it.

@nidz-the-fact nidz-the-fact changed the title request: Added "optimismSepolia" network for Tesnet request: Added "optimismSepolia" network for Testnet Sep 20, 2024
@enesozturk
Copy link
Contributor

@nidz-the-fact LGTM - thanks for the contribution. One request: could you run pnpm changeset script and create changeset file and push to PR? For questions:

  • Select all packages (changed or not changed)
  • Not major
  • Not minor
  • Give a short description that starts with a verb like "Add Optimisim Sepolia to exported networks)

Thanks!

enesozturk
enesozturk approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@enesozturk enesozturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - just changeset files please @nidz-the-fact

@nidz-the-fact
Copy link
Author

Approved - just changeset files please @nidz-the-fact

I have followed your instructions to add the files. Is it correct? Please check again. @enesozturk Thank you.
image

@enesozturk
Copy link
Contributor

@

Approved - just changeset files please @nidz-the-fact

I have followed your instructions to add the files. Is it correct? Please check again. @enesozturk Thank you. image

@nidz-the-fact No, it's not meeting the requirements that I mentioned above:

Select all packages (changed or not changed)
Not major
Not minor
Give a short description that starts with a verb like "Add Optimisim Sepolia to exported networks)

@nidz-the-fact
Copy link
Author

@

Approved - just changeset files please @nidz-the-fact

I have followed your instructions to add the files. Is it correct? Please check again. @enesozturk Thank you. image

@nidz-the-fact No, it's not meeting the requirements that I mentioned above:

Select all packages (changed or not changed)
Not major
Not minor
Give a short description that starts with a verb like "Add Optimisim Sepolia to exported networks)

Is this what I chose and did in 3 steps? @enesozturk
image
image
image

@enesozturk
Copy link
Contributor

enesozturk commented Sep 23, 2024 •
edited
Loading

@nidz-the-fact In step 2, just press enter - you shouldn't select anything :)

@nidz-the-fact
Copy link
Author

nidz-the-fact commented Sep 23, 2024 •
edited
Loading

@nidz-the-fact In step 2, just press enter - you shouldn't select anything :)

I press enter and cannot skip the option. @enesozturk
image

@nidz-the-fact
Copy link
Author

Is this correct? @enesozturk
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enesozturk enesozturk Awaiting requested review from enesozturk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nidz-the-fact @enesozturk